Messages in this thread | | | Date | Thu, 14 Oct 2010 12:06:09 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 2/5] tcm: Unify INQUIRY subsystem plugin handling |
| |
On Thu, Oct 14, 2010 at 02:54:47AM -0700, Nicholas A. Bellinger wrote: > It would make the most sense to just go ahead and set a pre-configured > struct queue_limits into transport_add_device_to_core_hba() from > subsystem specific ->create_virtdevice() code, and just drop whatever > unnecessary struct se_subsystem_api ops are duplicate of what is being > registered as defaults with struct queue_limits.
That sounds good. Note that by now it's not just queue_limits but also other paramters, so a rename of the structure might be a good idea.
| |