Messages in this thread | | | Date | Wed, 13 Oct 2010 10:20:06 +0200 | From | Samuel Ortiz <> | Subject | Re: [PATCH 1/1] mfd: Add TPS658621C device ID |
| |
Hi Mike,
On Wed, Oct 13, 2010 at 08:04:00AM +0200, Mike Rapoport wrote: > Samuel, > > Can you please queue this? Yes, I will.
Cheers, Samuel.
> > Andrew Chew wrote: > >Sending again. Can someone review for commit? > > > >This is a really simple change that adds a new valid device ID for the existing tps6586x PMU driver. > > > >The interface for this device should be identical to that of the > >TPS658521A. > > > >Signed-off-by: Andrew Chew <achew@nvidia.com> > > Acked-by: Mike Rapoport <mike@compulab.co.il> > > >--- > > drivers/mfd/tps6586x.c | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > >diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c > >index 117eb7c..b4931ab 100644 > >--- a/drivers/mfd/tps6586x.c > >+++ b/drivers/mfd/tps6586x.c > >@@ -47,6 +47,7 @@ > > /* device id */ > > #define TPS6586X_VERSIONCRC 0xcd > > #define TPS658621A_VERSIONCRC 0x15 > >+#define TPS658621C_VERSIONCRC 0x2c > > struct tps6586x_irq_data { > > u8 mask_reg; > >@@ -497,7 +498,8 @@ static int __devinit tps6586x_i2c_probe(struct i2c_client *client, > > return -EIO; > > } > >- if (ret != TPS658621A_VERSIONCRC) { > >+ if ((ret != TPS658621A_VERSIONCRC) && > >+ (ret != TPS658621C_VERSIONCRC)) { > > dev_err(&client->dev, "Unsupported chip ID: %x\n", ret); > > return -ENODEV; > > } > > > -- > Sincerely yours, > Mike.
-- Intel Open Source Technology Centre http://oss.intel.com/
| |