Messages in this thread | | | From | Linus Torvalds <> | Date | Wed, 13 Oct 2010 16:49:22 -0700 | Subject | Re: [GIT PULL] SCSI bug fixes for 2.6.36-rc7 |
| |
On Wed, Oct 13, 2010 at 6:45 AM, James Bottomley <James.Bottomley@suse.de> wrote: > This patch set fixes a couple of longstanding bugs in SCSI. The VPD > patch fix a possible buffer overrun in the VPD code (only tripped if the > device has a huge number of VPD pages). The other is where the status > return code on our BSG interface is wrongly right shifted one place.
Umm. That other patch seems to be utter crap.
> - hdr->device_status = status_byte(rq->errors); > + hdr->device_status = rq->errors && 0xff;
That's pure shit. Please look at it for one second, and don't send me crap like this.
Linus "grumpy" Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |