lkml.org 
[lkml]   [2010]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [GIT PULL] SCSI bug fixes for 2.6.36-rc7
    On Wed, Oct 13, 2010 at 6:45 AM, James Bottomley
    <James.Bottomley@suse.de> wrote:
    > This patch set fixes a couple of longstanding bugs in SCSI.  The VPD
    > patch fix a possible buffer overrun in the VPD code (only tripped if the
    > device has a huge number of VPD pages).  The other is where the status
    > return code on our BSG interface is wrongly right shifted one place.

    Umm. That other patch seems to be utter crap.

    > -       hdr->device_status = status_byte(rq->errors);
    > +       hdr->device_status = rq->errors && 0xff;

    That's pure shit. Please look at it for one second, and don't send me
    crap like this.

    Linus "grumpy" Torvalds
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-10-14 01:53    [W:0.020 / U:30.592 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site