lkml.org 
[lkml]   [2010]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[BUGFIX][PATCH v2] fix return value of scan_lru_pages in memory unplug
    On Wed, 13 Oct 2010 14:08:57 +0900 (JST)
    KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:

    > Also, this can be static. anyway
    > Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    yes.
    ==
    From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

    scan_lru_pages returns pfn. So, it's type should be "unsigned long"
    not "int".

    Note: I guess this has been work until now because memory hotplug tester's
    machine has not very big memory....
    physical address < 32bit << PAGE_SHIFT.

    Changelog v1->v2:
    - make the function static.

    Reported-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    ---
    mm/memory_hotplug.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    Index: mmotm-1008/mm/memory_hotplug.c
    ===================================================================
    --- mmotm-1008.orig/mm/memory_hotplug.c
    +++ mmotm-1008/mm/memory_hotplug.c
    @@ -646,7 +646,7 @@ static int test_pages_in_a_zone(unsigned
    * Scanning pfn is much easier than scanning lru list.
    * Scan pfn from start to end and Find LRU page.
    */
    -int scan_lru_pages(unsigned long start, unsigned long end)
    +static unsigned long scan_lru_pages(unsigned long start, unsigned long end)
    {
    unsigned long pfn;
    struct page *page;


    \
     
     \ /
      Last update: 2010-10-13 07:25    [W:0.024 / U:0.164 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site