| Date | Wed, 13 Oct 2010 09:27:37 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH 12/18] fs: Protect inode->i_state with the inode->i_lock |
| |
On Wed, Oct 13, 2010 at 11:15:55AM +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@redhat.com> > > We currently protect the per-inode state flags with the inode_lock. > Using a global lock to protect per-object state is overkill when we > coul duse a per-inode lock to protect the state. Use the > inode->i_lock for this, and wrap all the state changes and checks > with the inode->i_lock. > > Based on work originally written by Nick Piggin.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
|