Messages in this thread | | | Date | Wed, 13 Oct 2010 15:07:40 +1100 (EST) | From | James Morris <> | Subject | Re: [PATCH 1/5] secmark: do not return early if there was no error |
| |
On Tue, 12 Oct 2010, Eric Paris wrote:
> On Wed, 2010-10-13 at 10:38 +1100, James Morris wrote: > > On Tue, 12 Oct 2010, Eric Paris wrote: > > > > > Commit 4a5a5c73 attempted to pass decent error messages back to userspace for > > > netfilter errors. In xt_SECMARK.c however the patch screwed up and returned > > > on 0 (aka no error) early and didn't finish setting up secmark. This results > > > in a kernel BUG if you use SECMARK. > > > > > > > Does this need to go into current Linus? > > It's been broken since v2.6.35-rc1 so it's not exactly new, but yes, > it's broken and will bug like this in current Linus.
Acked-by: James Morris <jmorris@namei.org>
(Guessing this should go in via the networking tree).
-- James Morris <jmorris@namei.org>
| |