Messages in this thread Patch in this message | | | Subject | [PATCH] mfd: tps6507x - fix off-by-one value range checking | From | Axel Lin <> | Date | Wed, 13 Oct 2010 10:44:39 +0800 |
| |
We use msg[0] for device register. If bytes == (TPS6507X_MAX_REGISTER + 1), we got a buffer overflow when doing memcpy(&msg[1], src, bytes); Thus we must ensure bytes not greater than TPS6507X_MAX_REGISTER.
Signed-off-by: Axel Lin <axel.lin@gmail.com> --- drivers/mfd/tps6507x.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/tps6507x.c b/drivers/mfd/tps6507x.c index fc01976..33ba772 100644 --- a/drivers/mfd/tps6507x.c +++ b/drivers/mfd/tps6507x.c @@ -68,7 +68,7 @@ static int tps6507x_i2c_write_device(struct tps6507x_dev *tps6507x, char reg, u8 msg[TPS6507X_MAX_REGISTER + 1]; int ret; - if (bytes > (TPS6507X_MAX_REGISTER + 1)) + if (bytes > TPS6507X_MAX_REGISTER) return -EINVAL; msg[0] = reg; -- 1.7.2
| |