Messages in this thread | | | Subject | Re: [PATCH -v3 3/6] x86, NMI, Rewrite NMI handler | From | Peter Zijlstra <> | Date | Tue, 12 Oct 2010 08:49:53 +0200 |
| |
On Tue, 2010-10-12 at 14:45 +0800, Huang Ying wrote: > On Tue, 2010-10-12 at 14:40 +0800, Peter Zijlstra wrote: > > On Tue, 2010-10-12 at 14:37 +0800, Huang Ying wrote: > > > I just think two die_value make order more explicit. > > > > I think it sucks, you get to iterate the list twice for no gain. > > The gain is the code readability. And maybe we can split the list into 2 > in the future.
No, its not making sense, there's only one event source - the NMI, it doesn't make any sense what so ever to then artificially split it in two.
| |