Messages in this thread | | | Date | Tue, 12 Oct 2010 14:09:10 +0300 | Subject | Re: [PATCHv2 2/3] iovmm: add superpages support to fixed da address | From | Felipe Contreras <> |
| |
On Mon, Oct 11, 2010 at 6:33 PM, Guzman Lugo, Fernando <fernando.lugo@ti.com> wrote: >> > @@ -420,7 +431,8 @@ static void sgtable_fill_kmalloc(struct >> sg_table >> > *sgt, u32 pa, size_t len) >> > for_each_sg(sgt->sgl, sg, sgt->nents, i) { >> > size_t bytes; >> > >> > - bytes = iopgsz_max(len); >> > + bytes = max_alignment(da | pa); >> > + bytes = min(bytes, (size_t)iopgsz_max(len)); >> >> Why the size_t casting? > > To void this warning: > arch/arm/plat-omap/iovmm.c:440: warning: comparison of distinct pointer types lacks a cast
But how is that possible? iopgsz_max is returning constants, like SZ_1M, so they should not need casts, if anything, the cast should be done in iopgsz_max itself.
-- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |