Messages in this thread | | | Date | Mon, 11 Oct 2010 12:24:33 -0700 (PDT) | Subject | Re: [PATCH] net: clear heap allocations for privileged ethtool actions | From | David Miller <> |
| |
From: Ben Hutchings <bhutchings@solarflare.com> Date: Thu, 07 Oct 2010 22:34:44 +0100
> On Thu, 2010-10-07 at 14:10 -0700, Kees Cook wrote: >> Several other ethtool functions leave heap uncleared (potentially) by >> drivers. Some interfaces appear safe (eeprom, etc), in that the sizes >> are well controlled. In some situations (e.g. unchecked error conditions), >> the heap will remain unchanged in areas before copying back to userspace. >> Note that these are less of an issue since these all require CAP_NET_ADMIN. >> >> Cc: stable@kernel.org >> Signed-off-by: Kees Cook <kees.cook@canonical.com> ... > Acked-by: Ben Hutchings <bhutchings@solarflare.com>
So I've applied Kees's patch to net-2.6, and I'll merge net-2.6 into net-next-2.6 so I can resolve the vmalloc/kzalloc merge conflict before Stephen Rothwell and others have to deal with it in -next.
Thanks!
| |