lkml.org 
[lkml]   [2010]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/17] fs: icache lock i_count
On Wed, Sep 29, 2010 at 09:52:29PM -0700, Andrew Morton wrote:
> On Wed, 29 Sep 2010 22:18:37 +1000 Dave Chinner <david@fromorbit.com> wrote:
>
> > - if (atomic_read(&inode->i_count) != 1)
> > + if (inode->i_count != 1)
>
> This really should have been renamed to catch unconverted code.
>
> Such code usually wouldn't compile anyway, but it will if it takes the
> address of i_count only (for example).

If people do whacky things they'll lose - there is a reason why C has a
fairly strict type system after all. We've changed types of variables
all the time and we didn't run into problems.

> And maybe we should access this guy via accessor functions, dunno.

Seems like complete overkill.



\
 
 \ /
  Last update: 2010-10-03 22:25    [W:0.278 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site