Messages in this thread | | | Date | Fri, 8 Jan 2010 11:09:31 +0100 | Subject | Re: [PATCH] Convert the AB3100 driver to use threaded IRH | From | Linus Walleij <> |
| |
2010/1/8 Samuel Ortiz <sameo@linux.intel.com>:
> Linus, I fogot to mention that I removed IRQF_SAMPLE_RANDOM from your > request_threaded_irq() arguments, as it is scheduled for removal. See > Documentation/feature-removal-schedule.txt. > Please let me know if that's a problem for you.
I got the warning from checkpatch as well, and since this is an interrupt source which is truly random and we really *want* to sample for some IRQ randomness I do want that functionality in there.
However the fucntions to be used instead, rand_initialize_irq() + add_interrupt_randomness() aren't used anywhere else in the kernel than in the interrupt driver core.
But I don't mind being first ... if you upload your git tree to git.kernel.org I'll make a patch to reenable this the right way. (Or I can rewrite the previous patch, your choice.)
Linus
| |