lkml.org 
[lkml]   [2010]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH 1/2] i2c: Add support for Ux500/Nomadik I2C controller
From
Date
On Thu, 2010-01-07 at 21:37 +0100, Linus WALLEIJ wrote:
> > +++ b/drivers/i2c/busses/i2c-nmk.c
> (...)
> > + dev->irq = platform_get_irq(pdev, 0);
> > + ret = request_irq(dev->irq, i2c_irq_handler, IRQF_DISABLED,
> > + DRIVER_NAME, dev);
>
> Since I2C IRQs can be a bit tedious, could this be converted
> to a request_threaded_irq()? OK I know that is probably a bit
> intrusive and can very well be done later (so no blocker) but
> think about it.

hmm..I tried using request_threaded_irq, but seems not to be working at
the first step, did not debug further. So, I will post v2 patch fixing
the rest of your comments. Once I have this driver working fully with
threaded implementation, I will post a patch on top of it. Hope this is
OK.

Srinidhi



\
 
 \ /
  Last update: 2010-01-08 10:29    [from the cache]
©2003-2011 Jasper Spaans