lkml.org 
[lkml]   [2010]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] ep93xx_eth.c general cleanup
From
From: H Hartley Sweeten <hartleys@visionengravers.com>
Date: Tue, 5 Jan 2010 14:05:31 -0700

> General cleanup of the ep93xx_eth driver.
>
> 1) Use pr_fmt() to prefix the module name and __func__ to the error
> messages.
> 2) <linux/io.h> instead of <asm/io.h>
> 3) <mach/hardware.h> instead of <mach/ep93xx-regs.h> and <mach/platform.h>
> 4) Move the ep93xx_mdio_read (and ep93xx_mdio_write) function to eliminate
> the function prototype.
> 5) Change all the printk(<level> messages to pr_<level> and remove the
> __func__ argument.
> 6) Use platform_get_{resource/irq} to get the platform resources and add
> an error check.
> 7) Use resource_size() for request_mem_region() and ioremap().
> 8) Use %pM to print the MAC address at the end of the probe.
> 9) Use dev->dev_addr not data->dev_addr for the MAC argument because a
> random address could be used if the platform does not supply one.
>
> The message at the end of the probe is left as a printk since it displays
> cleaner without the function name that would be displayed with pr_info().
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Acked-by: Lennert Buytenhek <kernel@wantstofly.org>

Applied, thanks.


\
 
 \ /
  Last update: 2010-01-08 09:55    [W:0.030 / U:0.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site