lkml.org 
[lkml]   [2010]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] set_irq_noprobe shouldn't be __init
    On Tue, 5 Jan 2010 20:38:42 +0100
    Jean Delvare <khali@linux-fr.org> wrote:

    > Non-__init functions need to call set_irq_noprobe() so this function
    > shouldn't be marked __init. Also remove __init from set_irq_probe()
    > for consistency.
    >
    > Signed-off-by: Jean Delvare <khali@linux-fr.org>
    > Cc: Ralf Baechle <ralf@linux-mips.org>
    > Cc: Samuel Ortiz <sameo@linux.intel.com>
    > ---
    > kernel/irq/chip.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > --- linux-2.6.33-rc2.orig/kernel/irq/chip.c 2009-12-18 08:34:52.000000000 +0100
    > +++ linux-2.6.33-rc2/kernel/irq/chip.c 2010-01-05 17:21:38.000000000 +0100
    > @@ -682,7 +682,7 @@ set_irq_chip_and_handler_name(unsigned i
    > __set_irq_handler(irq, handle, 0, name);
    > }
    >
    > -void __init set_irq_noprobe(unsigned int irq)
    > +void set_irq_noprobe(unsigned int irq)
    > {
    > struct irq_desc *desc = irq_to_desc(irq);
    > unsigned long flags;
    > @@ -697,7 +697,7 @@ void __init set_irq_noprobe(unsigned int
    > raw_spin_unlock_irqrestore(&desc->lock, flags);
    > }
    >
    > -void __init set_irq_probe(unsigned int irq)
    > +void set_irq_probe(unsigned int irq)
    > {
    > struct irq_desc *desc = irq_to_desc(irq);
    > unsigned long flags;

    These non-__init callers will instantly crash, surely? Are there any
    reports of such crashes?

    If you're talking about new code then what is the status of that code?

    Right now I don't know if this patch is needed in 2.6.34, 2.6.33 or
    2.6.32.x and earlier.

    IOW: the changelog sucks :)

    Thanks.



    \
     
     \ /
      Last update: 2010-01-09 01:45    [W:0.026 / U:1.316 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site