Messages in this thread Patch in this message | | | Date | Fri, 8 Jan 2010 20:23:50 +0100 (CET) | From | Geert Uytterhoeven <> | Subject | checkpatch: EXPORT_SYMBOL() false positive |
| |
Hi Andy,
A patch from Finn causes a false positive in checkpatch:
| WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable | #13: FILE: arch/m68k/mac/config.c:801: | +EXPORT_SYMBOL(scc_a_pdev);
Test case from the patch:
--- a/arch/m68k/mac/config.c +++ b/arch/m68k/mac/config.c @@ -792,6 +792,32 @@ static struct mac_model mac_data_table[] = { } }; +struct platform_device scc_a_pdev = { + .name = "scc", + .id = 0, + .num_resources = ARRAY_SIZE(scc_a_rsrcs), + .resource = scc_a_rsrcs, +}; +EXPORT_SYMBOL(scc_a_pdev); + static void __init mac_identify(void) {
Gr{oetje,eeting}s, Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |