Messages in this thread | | | From | roel kluin <> | Date | Fri, 8 Jan 2010 13:25:29 +0100 | Subject | Re: [PATCH] KVM: dereference of NULL pointer in set_pal_result() |
| |
>> For the check "(p && p->exit_reason == EXIT_REASON_PAL_CALL", if p is NULL, the reference about "p->exit_reason == EXIT_REASON_PAL_CALL" won't be checked any more, so no issue here.
>> > p = kvm_get_exit_data(vcpu); >> > - if (p && p->exit_reason == EXIT_REASON_PAL_CALL) { >> > + if (!p) >> > + return; >> > + if (p->exit_reason == EXIT_REASON_PAL_CALL) { >> > p->u.pal_data.ret = result; >> > - return ; >> > + return; >> > } >> > INIT_PAL_STATUS_UNIMPLEMENTED(p->u.pal_data.ret); > > IMHO it's not the test but the INIT_PAL_STATUS_UNIMPLEMENTED() that does > the unwanted dereferencing, and that's fixed by the patch. > > Gabor
Correct. Thanks,
Roel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |