Messages in this thread | | | Subject | Re: [PATCH] lib/vsprintf.c: Add %pMF to format FDDI bit reversed MAC addresses | From | Joe Perches <> | Date | Thu, 07 Jan 2010 17:51:48 -0800 |
| |
On Fri, 2010-01-08 at 11:08 +1100, Simon Horman wrote: > In the vein of this, would it be worth adding some modifier to %i4 to > print addresses for ftp helpers? That is, %u,%u,%u,%u. I think > there are currently two users of that format string after Joe's latest > round of updates.
I think not. I think the comma separated uses are unusual enough to not support in lib/vsprintf.
I did submit a patch to support format strings for le32 and u32 ipv4 addresses.
> The users are net/netfilter/ipvs/ip_vs_ftp.c and > net/ipv4/netfilter/nf_nat_ftp.c. Prior to Joe's latest > changes ip_vs_ftp.c used %d,%d,%d,%d.
I submitted a couple of patches that should help.
o eventually remove NIPQUAD and NIPQUAD_FMT o consolidate the 2 netfilter "%u,%u,%u,%u" uses to a single function
| |