lkml.org 
[lkml]   [2010]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 6/8] mm: handle_speculative_fault()
On Thu, 7 Jan 2010, Linus Torvalds wrote:

> + if (brk < cur_brk)
> + goto slow_case;
> + if (brk == cur_brk)
> + goto out;
> +
> + vma = ok_to_extend_brk(mm, cur_brk, brk);
> + if (!vma)
> + goto slow_case;
> +
> + spin_lock(&mm->page_table_lock);


page_table_lock used to serialize multiple fast brks?

CONFIG_SPLIT_PTLOCK implies that code will not use this lock in fault
handling. So no serialization with faults.

Also the current code assumes vm_end and so on to be stable if mmap_sem is
held. F.e. find_vma() from do_fault is now running while vm_end may be changing
under it.




\
 
 \ /
  Last update: 2010-01-07 20:27    [W:0.181 / U:0.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site