[lkml]   [2010]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH v3] slab: initialize unused alien cache entry as NULL at alloc_alien_cache().
    understood. thanks!

    Pekka Enberg wrote:
    > Hi,
    > Haicheng Li wrote:
    >> Pekka Enberg wrote:
    >> > I can find a trace of Andi acking the previous version of this patch
    >> > but I don't see an ACK from Christoph nor a revieved-by from Matt. Was
    >> > I not CC'd on those emails or what's going on here?
    >> >
    >> Christoph said he will ack this patch if remove the change of
    >> MAX_NUMNODES (see below),
    >> so I add him directly as Acked-by in this revised patch. And also, I
    >> got review
    >> comments from Matt for v1 and changed the patch accordingly.
    >> Is it a violation of the rule? if so, I'm sorry, actually not quite
    >> clear with the rule.
    > See Section 14 of Documentation/SubmittingPatches. You should never add
    > tags unless they came from the said person. The ACKs from Andi is fine,
    > the one from Christoph is borderline but OK and the one from Matt is
    > _not_ OK.
    > I can fix those up but I'll wait from an explicit ACK from Christoph first.
    > Pekka

     \ /
      Last update: 2010-01-06 09:49    [W:0.021 / U:8.120 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site