lkml.org 
[lkml]   [2010]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: mmotm 2010-01-06-14-34 uploaded (kernel/cgroup)
KAMEZAWA Hiroyuki wrote:
> On Wed, 6 Jan 2010 17:08:49 -0800
> Randy Dunlap <randy.dunlap@oracle.com> wrote:
>
>> On Wed, 06 Jan 2010 14:34:36 -0800 akpm@linux-foundation.org wrote:
>>
>>> The mm-of-the-moment snapshot 2010-01-06-14-34 has been uploaded to
>>>
>>> http://userweb.kernel.org/~akpm/mmotm/
>>>
>>> and will soon be available at
>>>
>>> git://zen-kernel.org/kernel/mmotm.git
>>>
>>> It contains the following patches against 2.6.33-rc3:
>>
>> kernel/cgroup.c: In function 'cgroup_write_event_control':
>> kernel/cgroup.c:2949: error: implicit declaration of function 'eventfd_fget'
>> kernel/cgroup.c:2949: warning: assignment makes pointer from integer without a cast
>> kernel/cgroup.c:2955: error: implicit declaration of function 'eventfd_ctx_fileget'
>> kernel/cgroup.c:2955: warning: assignment makes pointer from integer without a cast
>> make[2]: *** [kernel/cgroup.o] Error 1
>>
>
> Hmm, how about this rather than adding #ifdefs..
> Paul, Li, how do you think ?

I think make CONFIG_CGROUPS select EVENTFD would be better.

> ==
> Cgroup's eventdf feature has depenedecy to EVENTFD
>
> This is a patch onto
> cgroup-implement-eventfd-based-generic-api-for-notifications.patch
>
> CC: Li Zefan <lizf@cn.fujitsu.com>
> CC: Kirill A. Shutemov <kirill@shutemov.name>
> CC: Paul Menage <menage@google.com>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> ---
> init/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: ref-mmotm/init/Kconfig
> ===================================================================
> --- ref-mmotm.orig/init/Kconfig
> +++ ref-mmotm/init/Kconfig
> @@ -509,6 +509,7 @@ endchoice
>
> menuconfig CGROUPS
> boolean "Control Group support"
> + depends on EVENTFD
> help
> This option adds support for grouping sets of processes together, for
> use with process control subsystems such as Cpusets, CFS, memory
>
>
>


\
 
 \ /
  Last update: 2010-01-07 03:43    [W:0.079 / U:1.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site