Messages in this thread | | | From | Mike Frysinger <> | Date | Wed, 6 Jan 2010 15:08:18 -0500 | Subject | Re: [Kgdb-bugreport] [PATCH 09/37] kgdb,blackfin: Add in kgdb_arch_set_pc for blackfin |
| |
On Wed, Jan 6, 2010 at 14:43, Jason Wessel wrote: > I pulled in this patch, and made the changes the Mike talked about with > respect to cleaning up the arch specific kgdb.c for blackfin. See the > attached patch. > > Your patch and the one here will go into kgdb-next and onto linux-next.
the Blackfin versions tail into the common probe_kernel_{read,write} funcs, so your patch causes an infinite recursion in the common case. as i hinted earlier, i'd like to see mm/access.c to have something like: -long probe_kernel_read(void *dst, void *src, size_t size) +long __probe_kernel_read(void *dst, void *src, size_t size) ... +long __weak probe_kernel_read(void *dst, void *src, size_t size) __attribute__((alias("__probe_kernel_read"))); that way the arch-specific probe_kernel_read can still fall back to the common __probe_kernel_read function. same goes for the write function.
also, i see you added "notrace" to the Blackfin probe_kernel_write ... was that intentional ? if so, this should probably go into include/linux/uaccess.h instead
otherwise, this looks pretty good. thanks for doing the footwork ! :) -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |