lkml.org 
[lkml]   [2010]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] elf_fdpic_core_dump(): fix build break in 2.6.33-rc1


On Wed, 6 Jan 2010, David Howells wrote:
>
> From: Daisuke HATAYAMA <d.hatayama@jp.fujitsu.com>
>
> Commit f6151dfea21496d43dbaba32cfcd9c9f404769bc causes ELF-FDPIC to break
> during building, so this patch fixes it together with a correction for the
> printk format.

The comment doesn't match the patch. There's no build breakage fix (the
actual fix was already merged, and your patch reflects that), there's only
a printk format "fix" that is actually a de-provement because it splits
the string across multiple lines.

So a strong NAK to this patch.

Linus


\
 
 \ /
  Last update: 2010-01-06 19:49    [W:1.570 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site