lkml.org 
[lkml]   [2010]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] generic sys_old_select
    On Wed, Jan 06, 2010 at 06:34:38PM +0100, Christoph Hellwig wrote:
    > On Wed, Jan 06, 2010 at 10:32:59AM -0700, Matthew Wilcox wrote:
    > > On Wed, Jan 06, 2010 at 06:21:12PM +0100, Christoph Hellwig wrote:
    > > > Add a generic implementation of the old select syscall, which expects it's
    > > > argument in a memory block and switch all architectures over to use it.
    > >
    > > Don't we want an ifdef around compat_sys_old_select() like the one
    > > around sys_old_select()?
    >
    > Because nothing in compat.c does it. If we want to bother saving those
    > few bites we should do it for more functions, and in a consistant way.

    Actually, I'd be a lot happier if we had lib/syscall/old_select.c, instead
    of cluttering fs/select.c with that. Objections?


    \
     
     \ /
      Last update: 2010-01-06 18:43    [W:0.017 / U:61.852 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site