Messages in this thread | | | Date | Wed, 6 Jan 2010 12:23:19 -0500 | From | Christoph Hellwig <> | Subject | Re: [PATCH V3] sort: Introduce generic list_sort function |
| |
On Tue, Jan 05, 2010 at 01:52:35PM +0100, Andi Kleen wrote: > > > Also it would seem cleaner to have it in a own file. > > > > That might make sense if we had a large number of generic sort > > functions and it was difficult to tell the code apart, but we've > > only got 2 right now.... > > I was more thinking of the case that it can be easily made a lib-y > and then eliminated by the linker on non modular kernels if not needed > (unfortunately that would require putting the EXPORT_SYMBOL somewhere else)
lib-y doesn't work together with EXPORT_SYMBOL, having the export outside would also always pull it in. These days the whole lib-y mess doesn't make sense anymore - if we really need an optional library symbol we can just pull it in through a Kconfig variable.
| |