Messages in this thread | | | Date | Wed, 6 Jan 2010 13:34:16 +1100 | From | Simon Horman <> | Subject | Re: [PATCH 6/8] net/netfilter/ipvs/ip_vs_ftp.c: Use standardized format in sprintf |
| |
On Tue, Jan 05, 2010 at 05:20:18PM -0800, Joe Perches wrote: > Use the same format string as net/ipv4/netfilter/nf_nat_ftp.c > to encode an ipv4 address and port. > > Both uses should be a single common function. > > Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Simon Horman <horms@verge.net.au>
> --- > net/netfilter/ipvs/ip_vs_ftp.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c > index 33e2c79..73f38ea 100644 > --- a/net/netfilter/ipvs/ip_vs_ftp.c > +++ b/net/netfilter/ipvs/ip_vs_ftp.c > @@ -208,7 +208,7 @@ static int ip_vs_ftp_out(struct ip_vs_app *app, struct ip_vs_conn *cp, > */ > from.ip = n_cp->vaddr.ip; > port = n_cp->vport; > - sprintf(buf, "%d,%d,%d,%d,%d,%d", NIPQUAD(from.ip), > + sprintf(buf, "%u,%u,%u,%u,%u,%u", NIPQUAD(from.ip), > (ntohs(port)>>8)&255, ntohs(port)&255); > buf_len = strlen(buf); > > -- > 1.6.6.rc0.57.gad7a > > -- > To unsubscribe from this list: send the line "unsubscribe lvs-devel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
| |