lkml.org 
[lkml]   [2010]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: move sys_mmap_pgoff from util.c
On Wed, 30 Dec 2009, Hugh Dickins wrote:

> Move sys_mmap_pgoff() from mm/util.c to mm/mmap.c and mm/nommu.c,
> where we'd expect to find such code: especially now that it contains
> the MAP_HUGETLB handling. Revert mm/util.c to how it was in 2.6.32.
>
> This patch just ignores MAP_HUGETLB in the nommu case, as in 2.6.32,
> whereas 2.6.33-rc2 reported -ENOSYS. Perhaps validate_mmap_request()
> should reject it with -EINVAL? Add that later if necessary.
>
> Signed-off-by: Hugh Dickins <hugh.dickins@tiscali.co.uk>

I think that -ENOSYS is the correcet response in the nommu case, but
I that can be added in a later patch.

Acked-by: Eric B Munson <ebmunson@us.ibm.com>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2010-01-04 13:41    [W:0.322 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site