[lkml]   [2010]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 41/97] mac80211: fix propagation of failed hardware reconfigurations
    From: Luis R. Rodriguez <>

    commit 24feda0084722189468a65e20019cdd8ef99702b upstream.

    mac80211 does not propagate failed hardware reconfiguration
    requests. For suspend and resume this is important due to all
    the possible issues that can come out of the suspend <-> resume
    cycle. Not propagating the error means cfg80211 will assume
    the resume for the device went through fine and mac80211 will
    continue on trying to poke at the hardware, enable timers,
    queue work, and so on for a device which is completley

    The least we can do is to propagate device start issues and
    warn when this occurs upon resume. A side effect of this patch
    is we also now propagate the start errors upon harware
    reconfigurations (non-suspend), but this should also be desirable
    anyway, there is not point in continuing to reconfigure a
    device if mac80211 was unable to start the device.

    For further details refer to the thread:

    Signed-off-by: Luis R. Rodriguez <>
    Signed-off-by: John W. Linville <>
    Signed-off-by: Greg Kroah-Hartman <>
    net/mac80211/util.c | 12 ++++++++++++
    1 files changed, 12 insertions(+), 0 deletions(-)

    diff --git a/net/mac80211/util.c b/net/mac80211/util.c
    index cbc5d20..51e0bd2 100644
    --- a/net/mac80211/util.c
    +++ b/net/mac80211/util.c
    @@ -1031,7 +1031,19 @@ int ieee80211_reconfig(struct ieee80211_local *local)

    /* restart hardware */
    if (local->open_count) {
    + /*
    + * Upon resume hardware can sometimes be goofy due to
    + * various platform / driver / bus issues, so restarting
    + * the device may at times not work immediately. Propagate
    + * the error.
    + */
    res = drv_start(local);
    + if (res) {
    + WARN(local->suspended, "Harware became unavailable "
    + "upon resume. This is could be a software issue"
    + "prior to suspend or a harware issue\n");
    + return res;
    + }

    ieee80211_led_radio(local, true);

     \ /
      Last update: 2010-01-05 01:59    [W:0.020 / U:9.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site