[lkml]   [2010]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] input: remove BKL from uinput open function
    On Friday 29 January 2010, Thadeu Lima de Souza Cascardo wrote:
    > Commit 8702965848ed4bee27486a3e3d2ae34ebba6dd83 has push down the BKL
    > into uinput open function. However, there's nothing that needs locking
    > in there.
    > Signed-off-by: Thadeu Lima de Souza Cascardo <>

    The change looks good, but the same driver also uses the BKL in the
    default_llseek function. It would be nice to get rid of that in the
    same patch, e.g. by adding a ".llseek = generic_file_llseek," line
    in the file_operations, or making it call nonseekable_open() if the
    driver does not require seek to do anything.


     \ /
      Last update: 2010-01-30 08:05    [W:0.021 / U:12.572 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site