Messages in this thread | | | Date | Sat, 30 Jan 2010 00:03:11 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [patch 06/10] affs: Convert semaphores to mutexes |
| |
On Fri, 29 Jan 2010, Christoph Hellwig wrote:
> On Fri, Jan 29, 2010 at 08:38:55PM -0000, Thomas Gleixner wrote: > > These semaphores are plain mutexes. Convert them to struct mutex. > > Looks good. > > > Map affs_[un]lock_dir() to affs_[un]lock_ext() instead of the "#define > > i_hash_lock i_ext_lock" magic. > > I'm not sure which of the remapping tricks is the worth one.. > > Btw, if we don't want lockdep to complain we'll need annotations on > affs_lock_dir as it's taken both on parent and child.
Can we postpone this to the point where an actual affs user runs with lockdep enabled ?
Thanks,
tglx
| |