lkml.org 
[lkml]   [2010]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] input: remove BKL from uinput open function
    Date
    Commit 8702965848ed4bee27486a3e3d2ae34ebba6dd83 has push down the BKL
    into uinput open function. However, there's nothing that needs locking
    in there.

    Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
    ---
    drivers/input/misc/uinput.c | 3 ---
    1 files changed, 0 insertions(+), 3 deletions(-)

    diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
    index d3f5724..18206e1 100644
    --- a/drivers/input/misc/uinput.c
    +++ b/drivers/input/misc/uinput.c
    @@ -34,7 +34,6 @@
    #include <linux/slab.h>
    #include <linux/module.h>
    #include <linux/init.h>
    -#include <linux/smp_lock.h>
    #include <linux/fs.h>
    #include <linux/miscdevice.h>
    #include <linux/uinput.h>
    @@ -284,7 +283,6 @@ static int uinput_open(struct inode *inode, struct file *file)
    if (!newdev)
    return -ENOMEM;

    - lock_kernel();
    mutex_init(&newdev->mutex);
    spin_lock_init(&newdev->requests_lock);
    init_waitqueue_head(&newdev->requests_waitq);
    @@ -292,7 +290,6 @@ static int uinput_open(struct inode *inode, struct file *file)
    newdev->state = UIST_NEW_DEVICE;

    file->private_data = newdev;
    - unlock_kernel();

    return 0;
    }
    --
    1.6.6


    \
     
     \ /
      Last update: 2010-01-29 22:29    [W:0.020 / U:0.536 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site