Messages in this thread | | | Date | Thu, 28 Jan 2010 08:24:26 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH] hid: Logitech G13 driver 0.0.4 |
| |
Hi!
> is because it appears there are two conditions that fb_sys_write() will > continue on to the copy_from_user() but still return an error code. In > these cases -EFBIG and -ENOSPEC are returned but it is possible the buffer > has still been modified. > > Again, like I said, I don't have a problem changing it. If it's wrong, > it's wrong no matter how many other drivers may take the same > approach.
I believe it is wrong.
> My intuition tells me it's wrong, but at the same time I'd like to know if > there's a reason behind the other drivers also ignoring the EFAULT. Or, > perhaps it simply started in one driver and everyone else patterned after > it just like I did the g13 driver.
I guess it is indeed a copy&paste problem...
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |