lkml.org 
[lkml]   [2010]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [dm-devel] [BUG] kernel 2.6.32.x hangs during boot process
On Thu, Jan 28, 2010 at 03:32:41PM +0900, Jun'ichi Nomura wrote:
> When MS_RDONLY, both freeze_bdev and thaw_bdev call deactivate_locked_super,
> which seems wrong. The change was introduced with the commit below:
>
> commit 4504230a71566785a05d3e6b53fa1ee071b864eb
> Author: Christoph Hellwig <hch@lst.de>
> Date: Mon Aug 3 23:28:35 2009 +0200
>
> freeze_bdev: grab active reference to frozen superblocks
>
> With the attached patch, both remount-ro and remount-rw are
> rejected as EBUSY on freezed device as expected.
>
> Christoph, do you think this is the right fix?

Indeed, this looks wrong in my original code, and the patch looks like
the correct fix. Thanks a lot!


Reviewed-by: Christoph Hellwig <hch@lst.de>



\
 
 \ /
  Last update: 2010-01-28 19:27    [W:0.086 / U:3.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site