[lkml]   [2010]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] mx3fb: some debug and initialisation fixes.
On mar, 2010-01-26 at 13:46 -0800, Andrew Morton wrote:
> On Wed, 20 Jan 2010 15:57:14 +0100
> Alberto Panizzo <> wrote:
> > Fix the kernel oops when dev_dbg is called with mx3_fbi->txd == NULL
> >
> > Fix the late initialisation of mx3fb->backlight_level.
> > If not, in the chain of function started by init_fb_chan(), in __blank() call
> > sdc_set_brightness(mx3fb, mx3fb->backlight_level) that will shut down
> > the CONTRAST PWM output.
> I guess these aren't the biggest bugs we ever had but I tagged the
> patch for backporting into 2.6.32.x anyway - the fixes are prety
> obvious.

Yes, apart of the debug part, the late initialisation of
mx3fb->backlight_level prevent screen switch-on on boot in my development
board. So for me (and for all hardware that make use of the CONTRAST PWM to
control the brightness) is important.

> Your email client replaces tabs with spaces. I fixed that up, but
> please do prevent it from happening next time.
> Documentation/email-clients.txt has some Evolution tips.

The Evolution client lose tabs in copy/past between mails....
I'll take more care on this in future.



 \ /
  Last update: 2010-01-27 10:47    [W:0.039 / U:2.684 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site