lkml.org 
[lkml]   [2010]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 1/2] cpufreq: ondemand: Refactor frequency increase code
From
Date

Acked-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>

On Tue, 2010-01-26 at 17:06 -0800, Mike Chan wrote:
> Make simpler to read and call.
>
> *** v3 - Always call when powersave_bias is enabled.
>
> Signed-off-by: Mike Chan <mike@android.com>
> ---
> drivers/cpufreq/cpufreq_ondemand.c | 25 ++++++++++++-------------
> 1 files changed, 12 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
> index 4b34ade..516d0fe 100644
> --- a/drivers/cpufreq/cpufreq_ondemand.c
> +++ b/drivers/cpufreq/cpufreq_ondemand.c
> @@ -443,6 +443,17 @@ static struct attribute_group dbs_attr_group_old = {
>
> /************************** sysfs end ************************/
>
> +static void dbs_freq_increase(struct cpufreq_policy *p, unsigned int freq)
> +{
> + if (dbs_tuners_ins.powersave_bias)
> + freq = powersave_bias_target(p, freq, CPUFREQ_RELATION_H);
> + else if (p->cur == p->max)
> + return;
> +
> + __cpufreq_driver_target(p, freq, dbs_tuners_ins.powersave_bias ?
> + CPUFREQ_RELATION_L : CPUFREQ_RELATION_H);
> +}
> +
> static void dbs_check_cpu(struct cpu_dbs_info_s *this_dbs_info)
> {
> unsigned int max_load_freq;
> @@ -520,19 +531,7 @@ static void dbs_check_cpu(struct cpu_dbs_info_s *this_dbs_info)
>
> /* Check for frequency increase */
> if (max_load_freq > dbs_tuners_ins.up_threshold * policy->cur) {
> - /* if we are already at full speed then break out early */
> - if (!dbs_tuners_ins.powersave_bias) {
> - if (policy->cur == policy->max)
> - return;
> -
> - __cpufreq_driver_target(policy, policy->max,
> - CPUFREQ_RELATION_H);
> - } else {
> - int freq = powersave_bias_target(policy, policy->max,
> - CPUFREQ_RELATION_H);
> - __cpufreq_driver_target(policy, freq,
> - CPUFREQ_RELATION_L);
> - }
> + dbs_freq_increase(policy, policy->max);
> return;
> }
>




\
 
 \ /
  Last update: 2010-01-28 00:41    [W:0.102 / U:29.356 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site