lkml.org 
[lkml]   [2010]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] perf,hw_breakpoint: add lockless reservation forhw_breaks
Frederic Weisbecker wrote:
> On Tue, Jan 26, 2010 at 01:25:19PM -0600, Jason Wessel wrote:
>
>> @@ -250,11 +326,16 @@ int reserve_bp_slot(struct perf_event *b
>>
>> mutex_lock(&nr_bp_mutex);
>>
>> + ret = dbg_hw_breakpoint_alloc(bp->cpu);
>> + if (ret)
>> + goto end;
>> +
>>
>
>
>
> This is totally breaking all the constraints that try to
> make the reservation cpu-wide/task-wide aware.
>

Agreed. I was unaware of all the various pieces that the toggle_bp
handled.

A revised series is on the way based on the off-list discussion.

Thanks,
Jason.



\
 
 \ /
  Last update: 2010-01-27 23:33    [W:0.067 / U:5.876 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site