Messages in this thread | | | Date | Wed, 27 Jan 2010 18:58:52 +0100 | From | Oleg Nesterov <> | Subject | Re: + exec-allow-core_pipe-recursion-check-to-look-for-a-value-of-1-rather -than-0.patch added to -mm tree |
| |
On 01/27, Oleg Nesterov wrote: > > Currently only d_coredump() needs this new feature, but please note > that ____call_usermodehelper() was already "uglified" for the coredumping > over the pipe. > > If we add sub_info->finit(), then probably we should move the code > under "if (sub_info->stdin)" from ____call_usermodehelper() to > core_pipe_setup() ?
And, perhaps, we should not change call_usermodehelper() and all its callers? If the caller needs ->finit() it can customize subprocess_info like call_usermodehelper_pipe() already does?
To clarify, I don't have a "strong" opinion, I am just asking.
Oleg.
| |