Messages in this thread | | | Date | Wed, 27 Jan 2010 17:10:49 +0200 | From | Pekka Enberg <> | Subject | Re: [PATCH 1/3] use lock for 64-bit stats |
| |
Nitin Gupta wrote: > +static void stat_dec(u32 *v) > +{ > + *v = *v - 1; > +} > + > +static void stat64_inc(struct ramzswap *rzs, u64 *v) > +{ > + spin_lock(&rzs->stat64_lock); > + *v = *v + 1; > + spin_unlock(&rzs->stat64_lock); > +} > + > +static void stat64_dec(struct ramzswap *rzs, u64 *v) > +{ > + spin_lock(&rzs->stat64_lock); > + *v = *v - 1; > + spin_unlock(&rzs->stat64_lock); > +} > + > +static u64 stat64_read(struct ramzswap *rzs, u64 *v) > +{ > + u64 val; > + > + spin_lock(&rzs->stat64_lock); > + val = *v; > + spin_unlock(&rzs->stat64_lock); > + > + return val; > +} > +#else > +#define stat_inc(v) > +#define stat_dec(v) > +#define stat64_inc(r, v) > +#define stat64_dec(r, v) > +#define stat64_read(r, v) > +#endif /* CONFIG_RAMZSWAP_STATS */
I think I complained about this before: the names are too generic and could collide with core kernel code. I think they ought to be called ramzsawp_stat*().
Pekka
| |