[lkml]   [2010]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] fs/binfmt_elf.c: fix a do-while statement.
On Tue, 26 Jan 2010 23:44:29 -0200 Thiago Farina <> wrote:

> > It is somewhat unconventional coding style and it'd be good if
> > checkpatch were to warn so that we don't _add_ such things to the tree.
> >
> > But IMO it's such a minor thing that once it _is_ in the tree, it's not
> > really worth the patch noise to go and fix it up.
> Yeah, much noise for a small thing. I will not fix more warnings like
> this in future.

I'd be OK with fixing things like this as part of a larger
"fs/binfmt_elf.c: coding-style fixes" or "fs/*elf.c: ...", etc. One
big hit. It's the little dribble of one-line fixes which I'd prefer to

 \ /
  Last update: 2010-01-27 03:11    [W:0.043 / U:1.516 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site