Messages in this thread | | | Date | Tue, 26 Jan 2010 09:46:41 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH 01/29] move acornfb's probe function to .devinit.text |
| |
On Sun, Jan 24, 2010 at 01:25:58 +0200, Alexey Dobriyan wrote: > gods, can you just send one patch for all framebuffer drivers? Well, I thought one logical change per changeset is the favourite way to go. And as the people Cc:d are different I think most people prefer it this way.
On Sun, Jan 24, 2010 at 01:28:13AM +0200, Alexey Dobriyan wrote: > On Sat, Jan 23, 2010 at 09:35:09PM +0100, Uwe Kleine-König wrote: > > -static int __init acornfb_probe(struct platform_device *dev) > > +static int __devinit acornfb_probe(struct platform_device *dev) > > Even more, if this function is marked __devinit, some other functions > can very well be marked __devinit, can you do this? Probably, the big pro after my patch is that modpost can warn about this. Actually this applies to all (initially) over 50 patches in this series. If you take my patches, squash them together and fix all called functions, I'm happy, too.
If you don't I might come back to this and do it myself.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |