lkml.org 
[lkml]   [2010]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [2.6.33-rc5] starting emacs makes lockdep warning
From
On Tue, Jan 26, 2010 at 3:45 PM, KOSAKI Motohiro
<kosaki.motohiro@jp.fujitsu.com> wrote:
> Hi
>
>> On Tue, Jan 26, 2010 at 02:01:12PM +0800, Am??rico Wang wrote:
>>
>> > I agree, it seems that patch is useless, since we already
>> > do lock_kernel() before calling __f_setown()...
>>
>> What's to prevent pid from being freed under us?  BKL won't...
>
> I don't understand this issue at all. so, this is stupid dumb question.
> Why can't we write following code?
>
>
>                enum pid_type type;
>                struct pid *pid;
>                if (!waitqueue_active(&tty->read_wait))
>                        tty->minimum_to_wake = 1;
>                spin_lock_irqsave(&tty->ctrl_lock, flags);
>                if (tty->pgrp) {
>                        pid = tty->pgrp;
>                        type = PIDTYPE_PGID;
>                } else {
>                        pid = task_pid(current);
>                        type = PIDTYPE_PID;
>                }
>                get_pid(pid)                                    // insert here
>                spin_unlock_irqrestore(&tty->ctrl_lock, flags);
>                retval = __f_setown(filp, pid, type, 0);
>                put_pid(pid)                                    // insert here
>

Yeah, this seems reasonable for me, but not sure if this is the best fix.
\
 
 \ /
  Last update: 2010-01-26 09:49    [W:0.054 / U:14.244 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site