Messages in this thread | | | From | David Brownell <> | Subject | Re: [PATCH 1/4] gpiolib: Introduce chip addition/removal notifier | Date | Tue, 26 Jan 2010 13:01:05 -0800 |
| |
On Tuesday 26 January 2010, Anton Vorontsov wrote: > > Just > > inline the little two blocking_notifier_call_chain() calls directly, > > making this a *LOT* simpler. > > I'd rather stay with gpio_call_chain() helper, it makes the code > a little bit prettier, IMO. Compare this:
The one without the wrapper is IMO more clear, since it doesn't obfuscate anything. Fewer lines of code, too. :)
Pretty is a good attribute ... but is a distant third to clarity.
| |