| Date | Tue, 26 Jan 2010 11:20:27 -0500 | From | Peter Jones <> | Subject | Re: [PATCH 07/29] move efifb's probe function to .devinit.text |
| |
On 01/23/2010 03:35 PM, Uwe Kleine-König wrote: > A pointer to efifb_probe is passed to the core via > platform_driver_register and so the function must not disappear when the > .init sections are discarded. Otherwise (if also having HOTPLUG=y) > unbinding and binding a device to the driver via sysfs will result in an > oops as does a device being registered late. > > An alternative to this patch is using platform_driver_probe instead of > platform_driver_register plus removing the pointer to the probe function > from the struct platform_driver.
__devinit looks reasonable enough to me.
Acked-By: Peter Jones <pjones@redhat.com>
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Cc: Peter Jones <pjones@redhat.com> > Cc: Krzysztof Helt <krzysztof.h1@poczta.fm> > Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> > Cc: Jaya Kumar <jayakumar.lkml@gmail.com> > Cc: Ralf Baechle <ralf@linux-mips.org> > Cc: Maciej W. Rozycki <macro@linux-mips.org> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Chandramouli Narayanan <mouli@linux.intel.com> > Cc: Huang Ying <ying.huang@intel.com> > --- > drivers/video/efifb.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c > index eb12182..2161f21 100644 > --- a/drivers/video/efifb.c > +++ b/drivers/video/efifb.c > @@ -201,7 +201,7 @@ static int __init efifb_setup(char *options) > return 0; > } > > -static int __init efifb_probe(struct platform_device *dev) > +static int __devinit efifb_probe(struct platform_device *dev) > { > struct fb_info *info; > int err;
-- Peter
The trouble with the global village are all the global village idiots. -- Paul Ginsparg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|