lkml.org 
[lkml]   [2010]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/6] tracing: Change trace_seq to use separate buffer
Frederic Weisbecker wrote:
> On Tue, Jan 19, 2010 at 03:34:16PM +0800, Lai Jiangshan wrote:
>> @@ -3124,6 +3126,8 @@ waitagain:
>> if (cnt >= PAGE_SIZE)
>> cnt = PAGE_SIZE - 1;
>>
>> + trace_seq_reset(&iter->seq);
>> +
>
>
>
> So we actually add a trace_seq_reset here.
> This should have been in the first patch, which drops
> the memset, and eventually modified here, just to avoid
> breaking things in the middle of a patchset.
>
> Things were already broken though before the memset dropping
> patch though in other ways, so it's not that important I guess...
>
>

There is no trace_seq_reset() before this patch applied.
trace_seq_init() in the first patch, has already reset it.

Things are not broken by the first patch, if I did not misunderstand.


\
 
 \ /
  Last update: 2010-01-26 04:29    [W:0.047 / U:5.816 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site