Messages in this thread | | | Subject | Re: [PATCH 1/2] lib: more scalable list_sort() | From | Artem Bityutskiy <> | Date | Sun, 24 Jan 2010 23:10:35 +0200 |
| |
On Sun, 2010-01-24 at 21:59 +0100, Andi Kleen wrote: > > Similarly, adding cond_resched() to list_sort means you can stop > > worrying about the scheduling latency impact of sorting long lists. > > I fail to see why you're making such a big deal out of this..... > > It's not easy to add it to a low level library function like list_sort() > because you would need to ensure that all callers are allowed to sleep. > > Or even if all callers currently allow it future ones might not. > > So it would need a new flag or so if needed, completely changing > the interface.
Don made IMO a good proposal for the caller to add cond_reshed() in its 'cmp()' callback, if needed. Shouldn't that work fine?
-- Best Regards, Artem Bityutskiy (Артём Битюцкий)
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |