Messages in this thread | | | Date | Sat, 23 Jan 2010 14:57:28 -0500 (EST) | From | Len Brown <> | Subject | Re: [PATCH 2/2] Default to ACPI reboots on newish X86 hardware |
| |
Hi Christian, I've replaced your previous patch in the acpi-test tree with this refreshed pair.
Note that the 2nd patch had some checkpatch issues. Perhaps you can run checkpatch before sending future patches.
WARNING: braces {} are not necessary for single statement blocks #35: FILE: arch/x86/kernel/reboot.c:464: + if (!dmi_get_date(DMI_BIOS_DATE, &year, NULL, NULL)) { + return 1; + }
WARNING: braces {} are not necessary for single statement blocks #38: FILE: arch/x86/kernel/reboot.c:467: + if (year == 0) { + return 1; + }
WARNING: braces {} are not necessary for single statement blocks #43: FILE: arch/x86/kernel/reboot.c:472: + if (year < 2003) { + return 0; + }
ERROR: Missing Signed-off-by: line(s)
total: 1 errors, 3 warnings, 47 lines checked
thanks, Len Brown, Intel Open Source Technology Center
| |