Messages in this thread | | | From | Mike Frysinger <> | Date | Sat, 23 Jan 2010 14:13:35 -0500 | Subject | Re: [PATCH v2] ftrace: unify arch_syscall_addr() implementations |
| |
On Sat, Jan 23, 2010 at 03:28, David Miller <davem@davemloft.net> wrote: > From: Mike Frysinger <vapier@gentoo.org> > Date: Sat, 23 Jan 2010 02:10:43 -0500 > >> Most implementations of arch_syscall_addr() are the same, so create a >> default weak version in common code. New arch ports don't have to waste >> time copying & pasting this simple function. The Blackfin version is >> going to be exactly the same for example. >> >> The s390/sparc versions need to be different, so document why. >> >> Signed-off-by: Mike Frysinger <vapier@gentoo.org> > > You can just have the extern declaration match whatever the > arch needs (long or int) in the generic ftrace.c code and > then unconditionally do the (unsigned long) case. > > That way even s390/sparc can use the generic implementation.
asm/syscall.h is the most reasonable location to move the decls to in asm/ ... people OK with that ? -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |