[lkml]   [2010]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[tip:x86/urgent] x86: Set hotpluggable nodes in nodes_possible_map
    Commit-ID:  3a5fc0e40cb467e692737bc798bc99773c81e1e2
    Author: David Rientjes <>
    AuthorDate: Wed, 20 Jan 2010 12:10:47 -0800
    Committer: Ingo Molnar <>
    CommitDate: Sat, 23 Jan 2010 06:21:57 +0100

    x86: Set hotpluggable nodes in nodes_possible_map

    nodes_possible_map does not currently include nodes that have SRAT
    entries that are all ACPI_SRAT_MEM_HOT_PLUGGABLE since the bit is
    cleared in nodes_parsed if it does not have an online address range.

    Unequivocally setting the bit in nodes_parsed is insufficient since
    existing code, such as acpi_get_nodes(), assumes all nodes in the map
    have online address ranges. In fact, all code using nodes_parsed
    assumes such nodes represent an address range of online memory.

    nodes_possible_map is created by unioning nodes_parsed and
    cpu_nodes_parsed; the former represents nodes with online memory and
    the latter represents memoryless nodes. We now set the bit for
    hotpluggable nodes in cpu_nodes_parsed so that it also gets set in

    [ hpa: Haicheng Li points out that this makes the naming of the
    variable cpu_nodes_parsed somewhat counterintuitive. However, leave
    it as is in the interest of keeping the pure bug fix patch small. ]

    Signed-off-by: David Rientjes <>
    Tested-by: Haicheng Li <>
    LKML-Reference: <>
    Cc: <>
    Signed-off-by: H. Peter Anvin <>
    arch/x86/mm/srat_64.c | 4 +++-
    1 files changed, 3 insertions(+), 1 deletions(-)

    diff --git a/arch/x86/mm/srat_64.c b/arch/x86/mm/srat_64.c
    index a271241..28c6876 100644
    --- a/arch/x86/mm/srat_64.c
    +++ b/arch/x86/mm/srat_64.c
    @@ -229,9 +229,11 @@ update_nodes_add(int node, unsigned long start, unsigned long end)
    printk(KERN_ERR "SRAT: Hotplug zone not continuous. Partly ignored\n");

    - if (changed)
    + if (changed) {
    + node_set(node, cpu_nodes_parsed);
    printk(KERN_INFO "SRAT: hot plug zone found %Lx - %Lx\n",
    nd->start, nd->end);
    + }

    /* Callback for parsing of the Proximity Domain <-> Memory Area mappings */

     \ /
      Last update: 2010-01-23 07:55    [W:0.022 / U:3.272 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site