lkml.org 
[lkml]   [2010]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 15/29] move omap24xxcam's probe function to .devinit.text
    Date
    A pointer to omap24xxcam_probe is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded. Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.

    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Acked-by: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>
    Acked-by: Trilok Soni <soni.trilok@gmail.com>
    Cc: Hans Verkuil <hverkuil@xs4all.nl>
    Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    ---
    drivers/media/video/omap24xxcam.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/media/video/omap24xxcam.c b/drivers/media/video/omap24xxcam.c
    index 7400eac..142c327 100644
    --- a/drivers/media/video/omap24xxcam.c
    +++ b/drivers/media/video/omap24xxcam.c
    @@ -1735,7 +1735,7 @@ static struct v4l2_int_device omap24xxcam = {
    *
    */

    -static int __init omap24xxcam_probe(struct platform_device *pdev)
    +static int __devinit omap24xxcam_probe(struct platform_device *pdev)
    {
    struct omap24xxcam_device *cam;
    struct resource *mem;
    --
    1.6.6
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-01-23 21:39    [W:0.021 / U:30.076 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site