Messages in this thread | | | Date | Fri, 22 Jan 2010 18:45:28 -0800 (PST) | Subject | Re: [RFC PATCH] net: NETDEV WATCHDOG should print something every time | From | David Miller <> |
| |
From: Jesse Brandeburg <jesse.brandeburg@intel.com> Date: Fri, 22 Jan 2010 13:43:33 -0800
> commit 5337407c changed NETDEV WATCHDOG messages into a message > that will only print once per driver load. This removed a significant amount > of information from an admin who might be missing that his system was having > NETDEV WATCHDOGs, esp since there is no other global counter available to > count these events.
It's not once per driver load, it's once globally.
Once per driver load would be in fact what I would actually consider more reasonable, so put the boolean state into struct netdev, and test it to decide whether to do the WARN_ON() print.
Doing a message every time is way overboard and is going to spam some people's systems to the point where they can't even diagnose the problem, so I'm not accepting a patch which does that.
| |